Issues with NonGeneric.Emit.Call #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arlm
force-pushed
the
master
branch
2 times, most recently
from
e57a954 to
51b5efb
Compare
arlm
added a commit
that referenced
this pull request
Jul 10, 2019
…eated from the non-generic Emit. Closes Pull-Request #3 Co-authored-by: chaplin89 <[email protected]>
|
Closed on referenced commit. @chaplin89, can you please add tests for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The function Sigil.NonGeneric.Emit.Call ends up calling this overload of Emit.Call:
public Emit Call(MethodInfo method, Type[] arglist = null)
That overload is for already builded types and, in fact, the inner MethodBuilder object does not seems to like the call to GetParameters() (NotSupportedException -> Type has not beed created).
Is it possible to fix this calling the other overload of Emit.Call?
Thanks!