Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rockchip64: uboot: fix stable mac address for rk3318-box #7930

Merged
merged 1 commit into from
Mar 9, 2025

Conversation

paolosabatino
Copy link
Contributor

@paolosabatino paolosabatino commented Mar 8, 2025

Description

After bump to v2025.01, rk3318-box do not receive anymore a stable mac address.
The reason is that u-boot is not able anymore to properly detect the ethernet device because the upstream (ie: mainline kernel) device tree is missing a mac-phy reset property. This PR adds:

&gmac2phy {
        resets = <&cru SRST_GMAC2PHY_A>, <&cru SRST_MACPHY>;
        reset-names = "stmmaceth", "mac-phy";
}

to u-boot arch/arm/dts/rk3328-u-boot.dtsi, otherwise u-boot silently fail to initialize the fast ethernet.

Also the patch that was carrying several fixes for various rockchip devices was wrongly ported from v2024.07 and has been fixed now, hence the large diff; anyway this is totally confined to rk3318-box board, so no one else is affected by this change.

How Has This Been Tested?

  • Tested on a rk3318 board and noticed a stable mac address

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings

@paolosabatino paolosabatino requested a review from a team March 8, 2025 21:16
@github-actions github-actions bot added size/large PR with 250 lines or more Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Mar 8, 2025
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 05 Milestone: Second quarter release and removed Needs review Seeking for review labels Mar 9, 2025
@paolosabatino paolosabatino merged commit fad71e1 into armbian:main Mar 9, 2025
12 checks passed
@paolosabatino paolosabatino deleted the fix-rk3318-mac-address branch March 9, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
05 Milestone: Second quarter release Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/large PR with 250 lines or more
Development

Successfully merging this pull request may close these issues.

2 participants