feat(config): Added json schema generator for providers #7
Conversation
|
The title of the Pull Request needs to be changed. |
dorisgjata
changed the title
|
I need to clean up some code from my previous commits |
dorisgjata
changed the title
|
I'd extract the logic out of |
| } | ||
| } | ||
| } | ||
| public void addBakeryCommandFields(String providerName, Field[] fields) { |
| } | ||
| } | ||
| } | ||
| public void addAccountCommandFields(String providerName, Field[] fields) { |
| public JSONObject providersFields = Providers.providersMetadata(); | ||
|
|
||
| public void addProviderCommandFields(String providerName, Field[] fields) { | ||
| JSONObject providerFields = (JSONObject) ((JSONObject) providersFields.get("providers")).get(providerName); |
There was a problem hiding this comment.
why the double cast? (JSONObject) ((JSONObject)....
| public void addBakeryCommandFields(String providerName, Field[] fields) { | ||
| JSONObject bakeryDefaultsFields = (JSONObject) ((JSONObject) ((JSONObject) providersFields.get("providers")) | ||
| .get(providerName)).get("bakeryDefaultsFields"); | ||
| if (providersFields != null && bakeryDefaultsFields != null) { |
There was a problem hiding this comment.
might want to use Objects.equals instead of !=, better null safety
| .get(providerName)).get("bakeryDefaultsFields"); | ||
| if (providersFields != null && bakeryDefaultsFields != null) { | ||
| for (Field f : fields) { | ||
| if (f.getAnnotation(Parameter.class) != null && bakeryDefaultsFields.get(f.getName()) != null) { |
There was a problem hiding this comment.
might want to use Objects.equals instead of !=, better null safety
| for (Field field : fields) { | ||
| accountFields.put(field.getName(), fieldType(field)); | ||
| } | ||
| if (providersFields != null && providersFields.get(providerName) != null) { |
There was a problem hiding this comment.
might want to use Objects.equals instead of !=, better null safety
| for (Field field : fields) { | ||
| bakeryFields.put(field.getName(), fieldType(field)); | ||
| } | ||
| if (providersFields != null && providersFields.get(providerName) != null) { |
There was a problem hiding this comment.
might want to use Objects.equals instead of !=, better null safety
|
|
||
| public JSONObject fieldType(Field field) { | ||
| JSONObject typeWrapper = new JSONObject(); | ||
| if (field.getAnnotation(LocalFile.class) != null) { |
There was a problem hiding this comment.
might want to use Objects.equals instead of !=, better null safety
| JSONObject typeWrapper = new JSONObject(); | ||
| if (field.getAnnotation(LocalFile.class) != null) { | ||
| typeWrapper.put("type", "upload"); | ||
| } else if (field.getAnnotation(Secret.class) != null) { |
There was a problem hiding this comment.
might want to use Objects.equals instead of !=, better null safety
cristhian-castaneda
force-pushed
the
master
branch
from
ea85c0e to
cc2d1ec
Compare
No description provided.