Add --add-opens to surefire for running tests on Java SE 17+ #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This probably needs to be in a profile where we check the Java version. That said, I wonder at what point we drop Java 8 support :) |
Certainly we will drop it when the main branch goes to 2.0 and SE 21 as the baseline. Pulling this code out into a separate legacy repo will also simplify things. For now I have added the profile. |
jamezp
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
The CDIInjectionEnricherTestCase relies on Weld being able to make protected/private fields accessible. This requires additional access permissions when running under Java SE 17+
Changes proposed in this pull request:
Add an override to the surefire plugin configuration to include a
--add-opens java.base/java.lang=ALL-UNNAMEDFixes #564