Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DIA-1168): create a new swiper component for infinite discovery #11556

Open
wants to merge 33 commits into
base: main
Choose a base branch
from

Conversation

iskounen
Copy link
Contributor

@iskounen iskounen commented Feb 14, 2025

This PR introduces a new swiper component that can be customized for Infinite Discovery. We previously shared the FancySwiper component with the Art Quiz, but this new component will allow us to take advantage of the Reanimated library, and will save time that we need to spend making sure that we don't introduce regressions to Art Quiz.

Simulator.Screen.Recording.-.iPhone.16.Plus.-.2025-02-26.at.15.27.33.mp4

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • introduced a new swiper component for infinite discovery

Need help with something? Have a look at our docs, or get in touch with us.

@iskounen iskounen self-assigned this Feb 14, 2025
@iskounen iskounen marked this pull request as draft February 14, 2025 12:57
@araujobarret araujobarret force-pushed the iskounen/spike/infinite-discovery-alternative-swipe branch from 6f0a02c to 894d8cb Compare February 19, 2025 09:13
@iskounen iskounen force-pushed the iskounen/spike/infinite-discovery-alternative-swipe branch from faa025c to 6e63e30 Compare February 27, 2025 00:17
@iskounen iskounen changed the title spike: infinite discovery back swipe feat(DIA-1168): create a new swiper component for infinite discovery Feb 27, 2025
@iskounen iskounen marked this pull request as ready for review February 28, 2025 18:09
@ArtsyOpenSource
Copy link
Contributor

This PR contains the following changes:

  • Dev changes (introduced a new swiper component for infinite discovery - iskounen)

Generated by 🚫 dangerJS against bad7724

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants