-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(DIA-1168): create a new swiper component for infinite discovery #11556
Open
iskounen
wants to merge
33
commits into
main
Choose a base branch
from
iskounen/spike/infinite-discovery-alternative-swipe
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(DIA-1168): create a new swiper component for infinite discovery #11556
iskounen
wants to merge
33
commits into
main
from
iskounen/spike/infinite-discovery-alternative-swipe
+580
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskounen
commented
Feb 14, 2025
iskounen
commented
Feb 14, 2025
6f0a02c
to
894d8cb
Compare
faa025c
to
6e63e30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new swiper component that can be customized for Infinite Discovery. We previously shared the
FancySwiper
component with the Art Quiz, but this new component will allow us to take advantage of the Reanimated library, and will save time that we need to spend making sure that we don't introduce regressions to Art Quiz.Simulator.Screen.Recording.-.iPhone.16.Plus.-.2025-02-26.at.15.27.33.mp4
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.