fix: submit form after formik values are saved #15430
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to fix: EMI-2376
After some digging and pointers from @erikdstock seems like the issue is that submit form is called before
formik.setValues
finished executing. And seems likesetValues doesn't return a promise, awaiting it doesn't ensure the values are updated.
- so trying to useuseEffect
with a dependency onformikContext.values
instead when address is saved.Seems to fix this concrete error but not sure it does not break something else :( Did some local testing and seems fine though....