Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DONT MERGE] feat: remove partner offer from primary label #6220

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

starsirius
Copy link
Member

@starsirius starsirius commented Nov 11, 2024

DON'T MERGE YET. Will need to coordinate deploy with artsy/force#14897, and we might want to include tracking changes.

To load and render the partner offer signals on the client-side and still render other primary labels (e.g. "increased interest" and "curators' pick") server-side, we'd want to remove partner offer from the primaryLabel field.

The separation of authenticated and unauthenticated data into different fields is also more aligned with schema design (although I agree the name now can be a bit confusing).

Note that I didn't remove it from the enum as I don't want to introduce breaking schema changes. I can follow up separately once the main work is in.

@artsy-peril
Copy link
Contributor

artsy-peril bot commented Nov 22, 2024

Fails
🚫

Hi there! 👋

We use conventional commit formatting which has not been detected in your PRs title.

Refer to README#327 and Conventional Commits for PR/commit formatting guidelines.


Warnings
⚠️ The V2 schema in this PR has breaking changes with Force. Remember to update the Force schema if necessary.

Type 'DeleteDiscoveryUserMutationInput' was removed
Type 'DeleteDiscoveryUserMutationPayload' was removed
Type 'DeleteDiscoveryUserResponseOrError' was removed
Type 'DeleteDiscoveryUserMutationFailure' was removed
Type 'DeleteDiscoveryUserMutationSuccess' was removed
Field 'deleteDiscoveryUserMutation' was removed from object type 'Mutation'

Generated by 🚫 dangerJS against 90be548

@starsirius starsirius changed the title [wip] remove partner offer from primary label [DONT MERGE] feat: remove partner offer from primary label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant