[DONT MERGE] feat: remove partner offer from primary label #6220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DON'T MERGE YET. Will need to coordinate deploy with artsy/force#14897, and we might want to include tracking changes.
To load and render the partner offer signals on the client-side and still render other primary labels (e.g. "increased interest" and "curators' pick") server-side, we'd want to remove partner offer from the
primaryLabel
field.The separation of authenticated and unauthenticated data into different fields is also more aligned with schema design (although I agree the name now can be a bit confusing).
Note that I didn't remove it from the enum as I don't want to introduce breaking schema changes. I can follow up separately once the main work is in.