refactor: don't repeat InternalIDField definition #6254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblandin
approved these changes
Nov 21, 2024
| @@ -245,6 +245,14 @@ export const InternalIDFields: GraphQLFieldConfigMap<any, ResolverContext> = { | |||
| }, | |||
| } | |||
|
|
|||
| export const InternalIDField: GraphQLFieldConfigMap<any, ResolverContext> = { | |||
There was a problem hiding this comment.
suggestion / non-blocking: Can we also reuse this definition within the GraphQLFieldConfigMaps defined above?
For example:
export const InternalIDFields: GraphQLFieldConfigMap<any, ResolverContext> = {
id: GlobalIDField,
internalID: InternalIDField
}| type: new GraphQLNonNull(GraphQLID), | ||
| resolve: ({ id }) => id, | ||
| }, | ||
| ...InternalIDField, |
There was a problem hiding this comment.
suggestion / non-blocking: Since this is just a single field and we're not spreading multiple fields, pulling in the specific field definition might be fine too:
internalID: InternalIDField
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of this code review comment: #6249 (comment)
Before I was repeating definition of
InternalIDfield in multiple places, now I simply spread the definition from a single place.