-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(EMI-2095): Add Swipeable component #263
base: main
Are you sure you want to change the base?
Conversation
react-native-gesture-handlerAuthor: Krzysztof Magiera Description: Experimental implementation of a new declarative API for gesture handling in react-native Homepage: https://github.com/software-mansion/react-native-gesture-handler#readme
|
version | react-native version |
---|---|
2.18.0+ | 0.73.0+ |
2.16.0+ | 0.68.0+ |
2.14.0+ | 0.67.0+ |
2.10.0+ | 0.64.0+ |
2.0.0+ | 0.63.0+ |
1.4.0+ | 0.60.0+ |
1.1.0+ | 0.57.2+ |
<1.1.0 | 0.50.0+ |
It may be possible to use newer versions of react-native-gesture-handler on React Native with version <= 0.59 by reverse Jetifying.
Read more on that here https://github.com/mikehardy/jetifier#to-reverse-jetify--convert-node_modules-dependencies-to-support-libraries
License
Gesture handler library is licensed under The MIT License.
Credits
This project has been build and is maintained thanks to the support from Shopify, Expo.io and Software Mansion
Community Discord
Join the Software Mansion Community Discord to chat about Gesture Handler or other Software Mansion libraries.
Gesture Handler is created by Software Mansion
Since 2012 Software Mansion is a software agency with experience in building web and mobile apps. We are Core React Native Contributors and experts in dealing with all kinds of React Native issues. We can help you build your next dream product – Hire us.
New dependencies added: react-native-gesture-handler
.
export interface SwipeableProps { | ||
children: React.ReactNode | ||
actionOnPress: () => void | ||
actionCompoent: React.ReactNode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actionComponent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we should leave it so flexible to be any kind of element, that's why I recommend going through DS first
The code looks fine, and simple to use however I feel like this component should be somehow in DS first, that's the common blackhole of Eigen's UI elements, they exist in product mockups but never in DS, once you search for the source of truth no one can find it. |
This PR resolves EMI-2095
Description
This PR adds a Swipeable component Palette using
react-native-gesture-handler
swipeableDemo
swipeable-android.mov
swipeable-ios.mov