Rw/feat/hyperlinks #215
Merged
Rw/feat/hyperlinks #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exilliar
added a commit
that referenced
this pull request
Apr 11, 2023
* Report v2 (#201) * assessment page saves in new v2 object * mostly working I think * child objects properly appear on server * includes materials and transport colours in report parent object now * removed comment * moved around a load of functions to (hopefully) make things a little cleaner * clean up * model object id now saved to report object to be more certain that correct model being displayed on view assessment page * child objects actually contain total carbon * wrote main parameter update function, don't know if it works yet * almost working * attempted to make things work * adding param function works (kinda) * cleaned up addParams method a little bit, should more reliably work now * model with new params being correctly uploaded * carbon heatmap inside Act! * started adding some controls for the viewer on the report viewer page * continued work on the viewer controls on the report viewing page * can change model views on the view report page * report viewer can load both v1 and v2 reports * updated v1 report to v2 works * added key to report viewer page (it's rubbish, but gets the job done) * removed most of the console.log's * added message to the final loading spinner on the assessment page * object parameter grouping now properly works * updated version number * cleaned things up * updated speckle viewer * almost working * working (as far as I know) * clean up * clean up * text update * text update 2 * added links (#215)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added links to https://www.arup.com/ and https://speckle.systems/ to the footer. Made the entire text a link rather than just the bolded part, just to give the user a bit more area to click on (I think this is better for accessibility).
I think that this pr covers #82 and #146 (I think there was a duplication of issues?)