quick includes from local folders (resolves #904) #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alaindresse
force-pushed
the
local-includes
branch
from
44f59ff
to
21ed6c8
Compare
|
Rejected because this is essentially a workaround and should be replaced by a proper solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (resolves #904 ) allows for antora includes resource ID like
include::module:family$filename[]to be resolved directly without relying on an antora configuration.This is enabled only if the setting
antora.enableAntoraSupportis false (to avoid conflicts with proper management of resource IDs) and ifantora.enableLocalIncludesis true (which I set at true by default in this PR).Changes are:
IncludeProcessorto handle the targetted resourceIds,antora.enableLocalIncludessettingantora.enableLocalIncludessetting (thank you Copilot for translation in languages I don't know)