Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update schemas for ASDF standard 1.6.0 #55

Merged
merged 6 commits into from
Mar 8, 2024

Conversation

braingram
Copy link
Contributor

@braingram braingram commented Feb 7, 2024

As several schemas reference ndarray-1.1.0 (which is not yet in a released version of ASDF standard 1.6.0) this PR temporarily adds a dev requirement for asdf-standard (which can be removed after asdf-format/asdf-standard#422 is merged and released). EDIT: asdf-standard 1.1.0 was released

@braingram braingram changed the title Standard 1p6p0 TEST: update for 1.6.0 standard Feb 7, 2024
@braingram braingram changed the title TEST: update for 1.6.0 standard Update schemas for ASDF standard 1.6.0 Feb 20, 2024
@braingram braingram marked this pull request as ready for review February 20, 2024 14:27
@braingram braingram closed this Feb 20, 2024
@braingram braingram reopened this Feb 20, 2024
@braingram braingram closed this Feb 20, 2024
@braingram braingram reopened this Feb 20, 2024
@braingram
Copy link
Contributor Author

The CI workflow disabled itself. I re-enabled it and closed/reopened to trigger the CI.

@braingram braingram force-pushed the standard_1p6p0 branch 2 times, most recently from 6e1892b to 34640f3 Compare February 20, 2024 15:19
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@braingram
Copy link
Contributor Author

The asdf-astropy devdeps failure is due to the time changes in 1.6.0 in asdf-format/asdf-standard#422 Once that PR is merged asdf-astropy can be updated to get time from the new astronomy manifest instead of core for 1.6.0.

Copy link
Contributor

@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@braingram
Copy link
Contributor Author

CI passed with released asdf-standard and dev asdf-astropy (except for the noted time tests above due to the asdf-standard update for 1.6.0):
https://github.com/asdf-format/asdf-coordinates-schemas/actions/runs/8163735550

I've removed the dev asdf-astropy testing requirement to allow merging this PR. This removal will cause CI failures (as the schemas in this package require asdf-astropy to be updated). Once this is merged and released, asdf-astropy can be updated to fix the errors.

The error (which stopped the CI):
https://github.com/asdf-format/asdf-coordinates-schemas/actions/runs/8177206846/job/22358346903?pr=55#step:5:1927

E                   TypeError: ICRS() missing 1 required positional argument: 'dec' (or first argument should be an instance of UnitSphericalRepresentation).

during testing of resources/schemas/frames/galactocentric-1.1.0.yaml asdf-astropy fails to convert the tag:astropy.org:astropy/coordinates/latitude-1.1.0 used in the example. Which makes sense as it does not yet register the manifest (added in this PR) that adds that tag.

@braingram braingram merged commit 4d521e4 into asdf-format:main Mar 8, 2024
4 of 11 checks passed
@braingram braingram deleted the standard_1p6p0 branch March 8, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants