-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a new dark theme. #147
base: master
Are you sure you want to change the base?
Conversation
@NoorMohamed-intern , The theme looks good but there are some discrepancies.
|
Yes, i noticed there are some inconsistencies in some pages and needed to changed manually. Do you have any idea to make it work smoothly? |
@NoorMohamed-intern , may be you can try changing the color of person's har to be little bit different or may be you can change the background color to be little bit lighter. You can experiment with it and submit whichever you feel is more elegant. |
The bg color has changed bit lighter. For the illustration to pop-up.
Yes, i changed it for my site. But how can a new user, change it (hair color/shirt color) from theme.js without changing it from source, ? |
@NoorMohamed-intern , As of now you can't change some internal colors (hair, face etc) from theme but you can change shirt, pants etc. |
@ashutosh1919 Okay, for now i changed background color to be bit lighter. |
@NoorMohamed-intern This looks quite good but I think we should further lighten the background colour a bit. Issues |
I added a new Black and yellow theme which looks awesome. I just wanted to share my theme.
NOTE :
-- I did come changes in text color for some pages. (ex : in accordion)
--Please check my example for reference.
Here is my portfolio example : https://noormohamed.netlify.app/#/home