Skip to content

Commit

Permalink
README formatting
Browse files Browse the repository at this point in the history
  • Loading branch information
ashwanthkumar committed Feb 20, 2015
1 parent df7ba5f commit ae120c7
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ password=thisaintapassword
</scms>
<piplines>
<pipeline name="Project-A-PullRequests">
<pipeline name="Project-A-PullRequests" template="Project-A-Build">
<materials>
<!-- Make sure the ref="..." value matches the one specified above -->
<scm ref="34293182-33e4-4459-a686-276d70387dfb">
Expand All @@ -45,7 +45,6 @@ password=thisaintapassword
</cruise>
```


## Under the hood
Under the hood, we exploit the fact that custom "data" as part of the [latestRevision](http://www.go.cd/documentation/developer/writing_go_plugins/scm_material/version_1_0/latest_revision.html) message is available during [latestRevisionSince](http://www.go.cd/documentation/developer/writing_go_plugins/scm_material/version_1_0/latest_revisions_since.html) message as well.
First time when we run, we store all the open PRs in the data bag as
Expand All @@ -68,8 +67,7 @@ First time when we run, we store all the open PRs in the data bag as
}
}
```
We store all the open PRs in this fashion. With this we can find if a PR has new commit and trigger a build accordingly. As soon as we schedule a build against a PR, we set the `"alreadyScheduled"` flag for the PR to true. When a PR is closed / no longer available we remove that PR from the list completely.
We batch all the PRs and schedule them sequentially one after the other. After every build we look for any new changes across all the PRs.
We store all the open PRs in this fashion. With this we can find if a PR has new commit and trigger a build accordingly. As soon as we schedule a build against a PR, we set the `"alreadyScheduled"` flag for the PR to true. When a PR is closed / no longer available we remove that PR from the list completely. We batch all the PRs and schedule them sequentially one after the other. After every build we look for any new changes across all the PRs.

## To Dos
- Clean up the code esp. the JSON SerDe part
Expand Down

0 comments on commit ae120c7

Please sign in to comment.