Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added popup #43

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added popup #43

wants to merge 2 commits into from

Conversation

haram082
Copy link
Collaborator

image

  • Created a learn more button that shows a popup for more info about p-recs
  • couldn't default to show popup at first render due to new render every time search function is used
  • Any feedback on the button or modal UI appreciated

Copy link
Collaborator

@evelynhasama evelynhasama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! i think we still need to have this open on first visit but this is good for now

templates/search.html Outdated Show resolved Hide resolved
templates/search.html Show resolved Hide resolved
templates/search.html Outdated Show resolved Hide resolved
templates/search.html Outdated Show resolved Hide resolved
Copy link
Collaborator

@evelynhasama evelynhasama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants