Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix download filename for RC versions #33

Closed
wants to merge 1 commit into from

Conversation

aaylward
Copy link
Contributor

@aaylward aaylward commented Nov 23, 2024

fixes #32

What is this?

This PR fixes filename resolution for release candidate version of protoc. RC names like 29.0-rc3 have release artifacts with names like 29.0-rc-3.... see the release assets for 29.0-rc3 or 28.0-rc2

Changes are visible to end-users: no

Test plan

  • Pretty much covered by existing test cases with example protoc version changed to LATEST
  • Added unit test to validate release_version -> artifact_name against supported versions

@CLAassistant
Copy link

CLAassistant commented Nov 23, 2024

CLA assistant check
All committers have signed the CLA.

@aaylward aaylward force-pushed the main branch 2 times, most recently from fe9c70e to ad27af1 Compare November 26, 2024 02:02
@aaylward aaylward changed the title fix filename for rc versions Fix download filename for RC versions Nov 27, 2024
Copy link
Member

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@alexeagle
Copy link
Member

Hm, I'm not able to push to your branch

To github.com:aaylward/toolchains_protoc.git
 ! [remote rejected] aaylward/main -> aaylward/main (permission denied)
error: failed to push some refs to 'github.com:aaylward/toolchains_protoc.git'

Will land in #37

@alexeagle alexeagle closed this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Examples fail to build with v29.0-rc3 or LATEST (when LATEST is a release candidate)
3 participants