Support for io.EOF to C.AVERROR_EOF mapping #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asticode
requested changes
Sep 21, 2024
|
Thanks again for the PR ❤️ Let me know whether you need a tag 👍 |
|
No worries! If I get a chance, I'll try and contribute an example for the audio FIFO implementation. Thank you for the great library! No tag needed for now - we have a pretty easygoing policy of allowing go.mod to use commits rather than tags. |
asticode
pushed a commit
that referenced
this pull request
Oct 23, 2024
* Support for io.EOF to C.AVERROR_EOF mapping * Requested changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, there's no mapping between the io.EOF returned by os.File or most io.Reader implementations and the astiav / ffmpeg ErrEof (C.AVERROR_EOF).
This PR adds a mapping in the event io.EOF is returned by the custom reader implementation.