Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling (most of) CI with no-test label #14622

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila added ci Related to internal CI tooling no-test Disable CI tests for a pull request labels Nov 27, 2024
@MichaReiser
Copy link
Member

MichaReiser commented Nov 27, 2024

I don't mind the change if other people find it useful, but I worry that it adds complexity to our CI jobs without being used much because it requires an extra label. I'm probably too lazy to add it, and not adding it has no actual cost to me. Would it make more sense to automatically apply the new behavior to draft PRs unless they have a specific label? Draft PRs already express the I'm not done yet without requiring an extra step from my side (and the gh CLI makes it very easy to publish in draft, publishing with a label is a bit more involved)

@dhruvmanila
Copy link
Member Author

Would it make more sense to automatically apply the new behavior to draft PRs unless they have a specific label because draft PRs already express the: I'm not done here.

Yeah, I think I'm more in favor of checking the draft status of the PR instead of label. I've asked @zanieb for their opinion on this, will wait until then. I'm happy to hear others opinion as well.

@AlexWaygood
Copy link
Member

One of the reasons I sometimes open draft PRs is to e.g. check it passes all CI before requesting the review of codeowners. Most CI can be run locally, it's true, but for some CI jobs it's much easier to just see how it does on GitHub (e.g. the ecosystem checks). So I'm not sure I'd be a huge fan of auto-disabling all CI for draft PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to internal CI tooling no-test Disable CI tests for a pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants