Update docs for eq-without-hash
#14885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dhruvmanila
reviewed
Dec 10, 2024
MichaReiser
changed the title
|
@KotlinIsland are you planning to follow up on @dhruvmanila's comment or would you prefer if someone from us updates the documentation? |
|
sorry, I'm just watching a shark movie. I'll have time in the next two days |
KotlinIsland
force-pushed
the
fix-eq_without_hash
branch
from
81d4e3f to
3be48f7
Compare
KotlinIsland
force-pushed
the
fix-eq_without_hash
branch
6 times, most recently
from
858a70c to
52482d2
Compare
KotlinIsland
force-pushed
the
fix-eq_without_hash
branch
from
52482d2 to
679405f
Compare
dhruvmanila
approved these changes
Dec 20, 2024
dhruvmanila
changed the title
eq-without-hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
resolves #14883
This PR removes the known limitation section in the documentation of
eq-without-hash. That is not actually a limitation as a subclass overriding the__eq__method would have its__hash__set toNoneimplicitly. The user should explicitly inherit the__hash__method from the parent class.Test Plan