Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[red-knot] Error out when an mdtest code block is unterminated #14965

Merged
merged 5 commits into from
Dec 14, 2024

Conversation

InSyncWithFoo
Copy link
Contributor

Summary

Resolves #14934.

Test Plan

Added a unit test.

@carljm carljm changed the title [red-knot] Error out when a code block is unterminated [red-knot] Error out when an mdtest code block is unterminated Dec 14, 2024
@AlexWaygood AlexWaygood added testing Related to testing Ruff itself red-knot Multi-file analysis & type inference labels Dec 14, 2024
Copy link
Contributor

github-actions bot commented Dec 14, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

crates/red_knot_test/src/parser.rs Outdated Show resolved Hide resolved
crates/red_knot_test/src/parser.rs Outdated Show resolved Hide resolved
@carljm
Copy link
Contributor

carljm commented Dec 14, 2024

Thank you!

@carljm carljm merged commit a80e934 into astral-sh:main Dec 14, 2024
20 checks passed
@InSyncWithFoo InSyncWithFoo deleted the rk-unterminated-code-block branch December 14, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
red-knot Multi-file analysis & type inference testing Related to testing Ruff itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[red-knot] mdtest should fail if you have a triple-backtick block that is unclosed
3 participants