[red-knot] ClassLiteral(<T>) is not a disjoint type from Instance(<metaclass of T>)
#14970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to the class's metaclass
AlexWaygood
requested review from
carljm,
MichaReiser and
sharkdp
as code owners
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A class is an instance of its metaclass, so
ClassLiteral("ABC")is not disjoint fromInstance("ABCMeta"). However, we erroneously consider the two types disjoint on themainbranch. This PR fixes that.This bug was uncovered by adding some more core types to the property tests that provide coverage for classes that have custom metaclasses. The additions to the property tests are included in this PR.
Test Plan
New unit tests and property tests added. Tested with:
cargo test -p red_knot_python_semanticQUICKCHECK_TESTS=100000 cargo test -p red_knot_python_semantic -- --ignored types::property_tests::stableThe assignability property test fails on this branch, but that's a known issue that exists on
main, due to #14899.