Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[red-knot] Add support for re-export conventions for imports #15848

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[red-knot] Add support for re-export conventions for imports #15848

wants to merge 1 commit into from

Conversation

dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Jan 31, 2025 •
edited
Loading

Summary

closes: #14099
closes: #15476

Test Plan

@dhruvmanila dhruvmanila added the red-knot Multi-file analysis & type inference label Jan 31, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 31, 2025

CodSpeed Performance Report

Merging #15848 will degrade performances by 4.5%

Comparing dhruv/re-export (250c6ea) with main (59be5f5)

Summary

❌ 1 regressions
✅ 31 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ red_knot_check_file[incremental] 4.8 ms 5 ms -4.5%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carljm carljm Awaiting requested review from carljm carljm will be requested when the pull request is marked ready for review carljm is a code owner

@MichaReiser MichaReiser Awaiting requested review from MichaReiser MichaReiser will be requested when the pull request is marked ready for review MichaReiser is a code owner

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood will be requested when the pull request is marked ready for review AlexWaygood is a code owner

@sharkdp sharkdp Awaiting requested review from sharkdp sharkdp will be requested when the pull request is marked ready for review sharkdp is a code owner

Assignees
No one assigned
Labels
red-knot Multi-file analysis & type inference
Projects
None yet
Milestone
No milestone
1 participant
@dhruvmanila