Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update replacement paths for AIR302 #16876

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

ashb
Copy link
Contributor

@ashb ashb commented Mar 20, 2025

I am one of the core developers of Airflow and working on the "airflow.sdk"
package, and this updates the recommended replacments to the correct
user-facing imports.1

cc @Lee-W @uranusjr

Summary

Test Plan

Hope and pray? 😉

I'm sure there are some snapshot files I'm supposed to fix first.

Footnotes

  1. https://github.com/apache/airflow/blob/33f0f1d639b53d4221757c8493b819684bd26d21/task-sdk/src/airflow/sdk/__init__.py#L68-L93

@ashb ashb force-pushed the fix-airflow302-replacment-paths branch from 12550d9 to ce11795 Compare March 20, 2025 17:20
@dhruvmanila dhruvmanila added rule Implementing or modifying a lint rule preview Related to preview mode features labels Mar 21, 2025
@dhruvmanila
Copy link
Member

I'm sure there are some snapshot files I'm supposed to fix first.

Yeah, you can run the following command to test:

cargo insta test -p ruff_linter --unreferenced reject 

And, the following to verify the snapshots:

cargo insta review

@ashb ashb force-pushed the fix-airflow302-replacment-paths branch from ce11795 to 254815a Compare March 21, 2025 09:36
Copy link
Contributor

github-actions bot commented Mar 21, 2025

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Copy link
Contributor

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ashb ashb force-pushed the fix-airflow302-replacment-paths branch from 254815a to 1a83790 Compare March 21, 2025 15:47
I am one of the core developers of Airflow and working on the "airflow.sdk"
package, and this updates the recommended replacments to the correct
user-faceing imports.

[^1]: https://github.com/apache/airflow/blob/33f0f1d639b53d4221757c8493b819684bd26d21/task-sdk/src/airflow/sdk/__init__.py#L68-L93
@ashb ashb force-pushed the fix-airflow302-replacment-paths branch from 1a83790 to 102aead Compare March 21, 2025 17:23
@MichaReiser MichaReiser merged commit b1deab8 into astral-sh:main Mar 21, 2025
22 checks passed
@ashb ashb deleted the fix-airflow302-replacment-paths branch March 24, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Related to preview mode features rule Implementing or modifying a lint rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants