[red-knot] support narrowing on constants in matches #16974
Merged
+95
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericmarkmartin
requested review from
carljm,
AlexWaygood,
sharkdp and
dcreager
as code owners
|
AlexWaygood
approved these changes
Mar 26, 2025
carljm
approved these changes
Mar 28, 2025
crates/red_knot_python_semantic/resources/mdtest/narrow/match.md
Outdated
Show resolved
Hide resolved
crates/red_knot_python_semantic/resources/mdtest/narrow/match.md
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #13694
The implementation here was suspiciously straightforward so please lmk if I missed something
Also some drive-by changes to DRY things up a bit
Test Plan
Add new tests to narrow/match.md