-
Notifications
You must be signed in to change notification settings - Fork 2k
feat(ci): build loongarch64 binaries in CI #15387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
As with astral-sh/python-build-standalone#653 I think we're blocked on clearing this with our lawyers first. |
Interesting... Just out of curiosity, what legal challenges/processes are we facing with this? |
Sanctions is my guess - https://www.tomshardware.com/news/us-govt-blacklists-loongson-and-inspur |
Same guess as mine but was wondering if they could just say it outright. |
Yeah, the sanctions. |
My two cents... (Disclaimer: IANAL and I'm Chinese, unaffiliated with Loongson though, so take my words with a grain of salt. I'm just trying to bring some constructive points forward because I am a LoongArch user and community contributor myself.) Technically the sanctions only affect the company entity, and LoongArch is just an abstract ISA, even though right now all readily available LoongArch CPU models are from Loongson. And the contributor is not a Loongson employee AFAIK. So maybe having anything to do with this PR doesn't imply any relationship with or endorsement of Loongson? On the other hand, like it or not politics is not going anywhere, and not producing LoongArch binaries wouldn't stop the community from doing so downstream, so maybe the net effect is just making community packagers' and LoongArch daily-drivers' lives harder. Is it possible to both keep being "compliant" and somehow not regress downstream UX when they want to just install |
Would be great to add this kind of testing as starting with 0.8.13 building |
0.8.14 fails too
|
FYI @andypost, here's the tracking issue for the rustix problem: bytecodealliance/rustix#1496. It appears to be unrelated to uv. |
@SkyBird233 thank you, following |
Hi @zanieb, were you able to hear back from your lawyers? |
I can't comment on that until we have a policy, sorry. We're working on it. |
Good to know, thanks. |
Summary
This PR adds support for building loongarch64 binaries in CI. As uv itself runs perfectly well on loongarch64 and with the latter's userbase steadily growing, it would be a good idea to ship prebuilt binaries to help them out.
Please note that as Ubuntu is not yet available for loongarch64, I have elected to use a Debian Trixie container maintained by community members. In addition, as Debian's pip does not allow installing modules system-wide, the workflow for loongarch64 installs additional modules in a virtual environment.
Test Plan
Tests are included in CI and the loongarch64 artifacts built in this workflow has been smoke tested.