Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new catalog type: map #429

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Create new catalog type: map #429

merged 3 commits into from
Nov 21, 2024

Conversation

delucchi-cmu
Copy link
Contributor

Creates a new type of catalog for non-point source data: map.

See science driver documentation for further details on the requirements: https://docs.google.com/document/d/1LVnorexA1BNHVhUPyfGwevO-iyk7xvGlvwU-1UcZr-M/edit?tab=t.0#heading=h.rmz8988nl0o4

Closes #412.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.04%. Comparing base (c27133d) to head (4fd5576).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #429      +/-   ##
==========================================
+ Coverage   93.02%   93.04%   +0.01%     
==========================================
  Files          47       48       +1     
  Lines        2123     2128       +5     
==========================================
+ Hits         1975     1980       +5     
  Misses        148      148              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

github-actions bot commented Nov 20, 2024

Before [c27133d] After [52975ae] Ratio Benchmark (Parameter)
14.4±1ms 14.8±0.7ms 1.03 benchmarks.Suite.time_inner_pixel_alignment
45.5±0.2ms 46.4±0.5ms 1.02 benchmarks.Suite.time_pixel_tree_creation
380±1ms 380±2ms 1 benchmarks.Suite.time_outer_pixel_alignment
109±0.8ms 110±1ms 1 benchmarks.Suite.time_paths_creation
1.04±0.02ms 1.04±0.03ms 1 benchmarks.time_test_cone_filter_multiple_order
22.5±0.04ms 22.3±0.4ms 0.99 benchmarks.MetadataSuite.time_load_partition_info_order6
93.6±0.4ms 93.0±2ms 0.99 benchmarks.MetadataSuite.time_load_partition_join_info
125±1ms 124±1ms 0.99 benchmarks.time_test_alignment_even_sky
94.6±1ms 92.8±0.9ms 0.98 benchmarks.MetadataSuite.time_load_partition_info_order7

Click here to view all benchmarks.

@delucchi-cmu delucchi-cmu merged commit c39621d into main Nov 21, 2024
11 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/412/maps branch November 21, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement MAP catalog type
2 participants