Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vectorize polygon validation #431

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Vectorize polygon validation #431

merged 1 commit into from
Nov 21, 2024

Conversation

camposandro
Copy link
Contributor

Vectorize the polygon convexity / degeneracy check.

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.01%. Comparing base (c27133d) to head (4a3b15c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #431      +/-   ##
==========================================
- Coverage   93.02%   93.01%   -0.01%     
==========================================
  Files          47       47              
  Lines        2123     2120       -3     
==========================================
- Hits         1975     1972       -3     
  Misses        148      148              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

Before [c27133d] After [e4cac85] Ratio Benchmark (Parameter)
93.5±0.4ms 94.1±0.6ms 1.01 benchmarks.MetadataSuite.time_load_partition_join_info
45.7±0.5ms 46.1±0.5ms 1.01 benchmarks.Suite.time_pixel_tree_creation
23.0±0.3ms 23.0±0.07ms 1 benchmarks.MetadataSuite.time_load_partition_info_order6
93.3±0.6ms 93.5±0.2ms 1 benchmarks.MetadataSuite.time_load_partition_info_order7
14.1±0.8ms 14.2±1ms 1 benchmarks.Suite.time_inner_pixel_alignment
388±2ms 386±1ms 1 benchmarks.Suite.time_outer_pixel_alignment
110±0.7ms 111±0.8ms 1 benchmarks.Suite.time_paths_creation
125±2ms 125±0.6ms 1 benchmarks.time_test_alignment_even_sky
1.04±0.03ms 1.03±0.03ms 0.99 benchmarks.time_test_cone_filter_multiple_order

Click here to view all benchmarks.

@camposandro camposandro merged commit 635816f into main Nov 21, 2024
11 checks passed
@camposandro camposandro deleted the vectorize-polygon-check branch November 21, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants