Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove margin fine filtering, and healpy dependency. #434

Merged
merged 26 commits into from
Nov 26, 2024

Conversation

delucchi-cmu
Copy link
Contributor

@delucchi-cmu delucchi-cmu commented Nov 25, 2024

Merge work from margin branch, to remove margin fine filtering, and migrate healpix math from healpy to cds-healpix.

delucchi-cmu and others added 25 commits November 18, 2024 10:50
* Remove margin fine filtering.

* Remove unused unseen.
…unds

Use cdshealpix for margin pixel finding.
* Use astropy for ang2vec conversion

* Allow for kwargs in ang2vec
Use mindist instead of resol for margin filter
Replace healpix with cdshealpix for pixel math operations
* Use mocpy in box filtering

* Update tests

* Ensure moc is correct in box filter test

* Remove unused healpy methods

* Pin mocpy
Copy link

github-actions bot commented Nov 25, 2024

Before [c39621d] After [260a922] Ratio Benchmark (Parameter)
23.3±0.08ms 23.5±0.2ms 1.01 benchmarks.MetadataSuite.time_load_partition_info_order6
94.6±0.7ms 95.0±0.8ms 1.01 benchmarks.MetadataSuite.time_load_partition_info_order7
94.7±0.4ms 95.4±0.8ms 1.01 benchmarks.MetadataSuite.time_load_partition_join_info
13.1±0.9ms 13.3±0.4ms 1.01 benchmarks.Suite.time_inner_pixel_alignment
126±0.5ms 128±0.7ms 1.01 benchmarks.time_test_alignment_even_sky
1.03±0.02ms 1.04±0.02ms 1.01 benchmarks.time_test_cone_filter_multiple_order
381±2ms 380±4ms 1 benchmarks.Suite.time_outer_pixel_alignment
45.8±0.5ms 46.0±0.5ms 1 benchmarks.Suite.time_pixel_tree_creation
111±0.7ms 110±0.7ms 0.98 benchmarks.Suite.time_paths_creation

Click here to view all benchmarks.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 98.97959% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.90%. Comparing base (c39621d) to head (b14bc14).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/hats/inspection/visualize_catalog.py 96.15% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #434      +/-   ##
==========================================
- Coverage   93.03%   92.90%   -0.14%     
==========================================
  Files          48       47       -1     
  Lines        2125     2029      -96     
==========================================
- Hits         1977     1885      -92     
+ Misses        148      144       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delucchi-cmu delucchi-cmu merged commit ad6efa0 into main Nov 26, 2024
11 checks passed
@delucchi-cmu delucchi-cmu deleted the merge_conflicts branch November 26, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants