-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove margin fine filtering, and healpy dependency. #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove margin fine filtering. * Remove unused unseen.
…unds Use cdshealpix for margin pixel finding.
* Use astropy for ang2vec conversion * Allow for kwargs in ang2vec
Use mindist instead of resol for margin filter
…ents Plotting Improvements
Replace healpix with cdshealpix for pixel math operations
* Use mocpy in box filtering * Update tests * Ensure moc is correct in box filter test * Remove unused healpy methods * Pin mocpy
Click here to view all benchmarks. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #434 +/- ##
==========================================
- Coverage 93.03% 92.90% -0.14%
==========================================
Files 48 47 -1
Lines 2125 2029 -96
==========================================
- Hits 1977 1885 -92
+ Misses 148 144 -4 ☔ View full report in Codecov by Sentry. |
camposandro
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge work from
margin
branch, to remove margin fine filtering, and migrate healpix math from healpy to cds-healpix.