Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Catalog Lazy Representation #514

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

smcguire-cmu
Copy link
Contributor

  • Changes index column from healpix_29 divisions to healpix pixels
  • Adds warning that catalog is only lazily read

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (margin@8269182). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/lsdb/catalog/dataset/dataset.py 75.00% 1 Missing ⚠️
src/lsdb/catalog/dataset/healpix_dataset.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             margin     #514   +/-   ##
=========================================
  Coverage          ?   97.47%           
=========================================
  Files             ?       41           
  Lines             ?     1626           
  Branches          ?        0           
=========================================
  Hits              ?     1585           
  Misses            ?       41           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@camposandro camposandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks great! Can we just update the images of the Getting Started docs to show the current representation? the second image is unrelated to this change but it still shows a _hipscat_index column.

Base automatically changed from margin to main November 26, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants