covert shape-getting to method #70
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwcraig
requested changes
Jun 30, 2025
| def test_width_height(self, data: np.ndarray): | ||
| self.image.load_image(NDData(data=data)) | ||
| assert self.image.get_shape().width == 150 | ||
| assert self.image.get_shape().height == 100 |
There was a problem hiding this comment.
Can you please also add a test that get_shape returns an ImageShape?
| ] | ||
|
|
||
| ImageShape = namedtuple("ImageShape", ["width", "height"]) |
There was a problem hiding this comment.
Thinking out loud here...is there any way to avoid declaring ImageShape as something that needs to be imported by backends? For type hinting we could have get_shape(..) -> tuple[int, int] and then have get_shape return an ImgeShape that is defined inside of get_shape.
Or, I suppose, we could follow the Array API specification and just return a plain tuple...
Not against named tuples, but trying to think of ways to minimize the imports for backends.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As diuscussed with @mwcraig out-of-band, we realized image_height and image_width shouldn't be attributes since it may be label dependent. This changes them to be method-accessible instead of attributes