Adding deprecation decorators from astropy #1435
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we discussed in #1430, these decorators from astropy are very handy to deprecate keywords and methods. Handling the case of removing kwarg was added in version 2.0.12 and 3.1.2, so we need to keep these around in astroquery until the minimum required version covers these.
@keflavich - what do you think, should these live in an
extern
directory or directly in utils? These are around for astroquery internal usage only, so we may not even need the changelog entry.