-
-
Notifications
You must be signed in to change notification settings - Fork 417
Euclid: new method to retrieve scientific LE3 products #3313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cosmoJFH
wants to merge
27
commits into
astropy:main
Choose a base branch
from
esdc-esac-esa-int:ESA_euclid_EUCLIDMNGT-1275_LE3_search_capability
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
f294440
EUCLIDMNGT-1275 New method get_scientific_data_product_list
b021e33
EUCLIDMNGT-1275 New method get_scientific_data_product_list
f89022b
EUCLIDMNGT-1275 Update example
27313a6
EUCLIDMNGT-1275 Update product types and documentation
5105576
EUCLIDMNGT-1275 Update product types and documentation
0cc0da1
EUCLIDMNGT-1275 New category PHZ
3d135dd
EUCLIDMNGT-1275 New category PHZ
aa5864e
EUCLIDMNGT-1275 sort categories in the help
3b24cd3
EUCLIDMNGT-1275 rename parameter dataset to dataset_release
0e7e4d0
EUCLIDMNGT-1275 rename parameter dataset to dataset_release
c6dd7e5
EUCLIDMNGT-1275 Update help info
e0278bc
EUCLIDMNGT-1275 Remove wrong files
19b9c05
EUCLIDMNGT-1275 Update implementation
5b47cbe
EUCLIDMNGT-1275 Update help info
bd5f70c
EUCLIDMNGT-1275 Update variable names
a2ce748
EUCLIDMNGT-1275 Update comments for Q1 data release
c2374d2
EUCLIDMNGT-1275 merge categories 'SEL 'Wide Post-recon' a…
70ffeff
EUCLIDMNGT-1275 final changes from the archive scientists
8c96881
EUCLIDMNGT-1275 include PR reference
e4ed3d2
Merge branch 'main' into ESA_euclid_EUCLIDMNGT-1275_LE3_search_capabi…
cosmoJFH ff97448
EUCLIDMNGT-1275 Fix codestyle: trailing whitespace
c470938
EUCLIDMNGT-1275 Include PR reference
f89cdba
EUCLIDMNGT-1275 Remove duplicated information
ea52f13
EUCLIDMNGT-1275 Fix indentation
c861abc
EUCLIDMNGT-1275 Include changes suggested by the astroquery team
229c74d
EUCLIDMNGT-1275 Fix bug to retrieve data by group
f9bed5d
EUCLIDMNGT-1275 move the description of the method get_scientific_pro…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a small side note from someone not exactly familiar with Euclid data products and use cases, so I could easily be in the wrong:
I'm not sure about the naming, isn't science products returned with
get_product_list
, too? maybe swapscientific
tohighlevel
or something else? Or do you expect the users mostly using this method to access data?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will ask to the Euclid team at ESAC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually, we may revise the names of the methods in the EuclidClass to e.g., homogenize the method names and reduce their length - but that is well beyond the scope of this task. So we would leave the present name of this method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, that sounds good.