Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing reference for Act object destructor #51

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

TheBitFighter
Copy link
Contributor

When using smart pointer objects, the compiler expects a call to the destructor, but there is no destructor implementation in source. This fixes the issue by using the default destructor for the time being.

@rmanohar
Copy link
Member

rmanohar commented Dec 27, 2024

I'd fix this slightly differently: have an empty destructor with a placeholder comment that says that we need to implement it properly and clean up all memory. If you'd like to do this, let me know; otherwise I can do this and push a fix. It's also okay to just use the default and put a comment next to it indicating that this needs to be fixed properly down the road.

@rmanohar rmanohar merged commit ca6f192 into asyncvlsi:master Dec 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants