Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect missing / unknown dependencies errors in newer versions of Paper #81

Merged
merged 4 commits into from
Jul 4, 2024
Merged

Detect missing / unknown dependencies errors in newer versions of Paper #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
987820f
Add logs for unknown/missing dependency error in 1.20.4
pavog Jul 4, 2024
cdafe59
Adjust regex pattern to match dependency error message with and witho…
pavog Jul 4, 2024
2ebce70
Add tests
pavog Jul 4, 2024
649e533
Add logs and tests to test multiple dependencies in 1.20.4
pavog Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Analysis/Problem/Bukkit/PluginDependenciesProblem.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,9 @@ public function getMessage(): string
*/
public static function getPatterns(): array
{
return ['/Could not load \'(plugins[\/\\\]((?!\.jar).*)\.jar)\' in folder \'[^\']+\'\norg\.bukkit\.plugin\.UnknownDependencyException\: Unknown\/missing dependency plugins: \[([\w ,]+)\]/'];
return [
'/Could not load \'(plugins[\/\\\]((?!\.jar).*)\.jar)\' in (?:folder )?\'[^\']+\''
. '\norg\.bukkit\.plugin\.UnknownDependencyException\: Unknown\/missing dependency plugins: \[([\w ,]+)\]/'];
}

/**
Expand Down
4 changes: 3 additions & 1 deletion src/Analysis/Problem/Bukkit/PluginDependencyProblem.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,9 @@ public function getMessage(): string
*/
public static function getPatterns(): array
{
return ['/Could not load \'(plugins[\/\\\]((?!\.jar).*)\.jar)\' in folder \'[^\']+\'\norg\.bukkit\.plugin\.UnknownDependencyException\: (?:(\w+)\n|Unknown dependency (\w+)\.)/'];
return [
'/Could not load \'(plugins[\/\\\]((?!\.jar).*)\.jar)\' in (?:folder )?\'[^\']+\''
. '\norg\.bukkit\.plugin\.UnknownDependencyException\: (?:(\w+)\n|Unknown dependency (\w+)\.)/'];
}

/**
Expand Down
0 ...it/Paper/paper-multiple-dependencies.json → ...r/paper-multiple-dependencies-1-18-2.json
View file
Open in desktop
File renamed without changes.
0 ...kit/Paper/paper-multiple-dependencies.log → ...er/paper-multiple-dependencies-1-18-2.log
View file
Open in desktop
File renamed without changes.
Loading
Loading