Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add problem and solution for Auth server unreachable #85

Merged
merged 6 commits into from
Aug 8, 2024
Merged

Add problem and solution for Auth server unreachable #85

merged 6 commits into from
Aug 8, 2024

Conversation

tomjpeg
Copy link
Collaborator

@tomjpeg tomjpeg commented Aug 8, 2024

No description provided.

@tomjpeg tomjpeg requested a review from matthi4s August 8, 2024 11:48
pavog
pavog reviewed Aug 8, 2024
View reviewed changes
Copy link
Member

@pavog pavog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the file name for vanilla-auth-key.log is too vague.
I would prefer to rename the file, e.g. to minecraft-auth-servers-unreachable.log. So that it is clearer what exactly is in this log.

@tomjpeg tomjpeg requested review from pavog and removed request for matthi4s August 8, 2024 13:56
@tomjpeg tomjpeg merged commit 7fce147 into master Aug 8, 2024
3 checks passed
@JulianVennen JulianVennen deleted the add-auth-server-down-problem branch August 12, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavog pavog pavog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomjpeg @pavog