Detect more crash reports from NeoForge + detect version in crash reports from NeoForge #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… NeoForgeVersionInformation.php, add pattern to detect crash report as NeoForge crash report in NeoForgeCrashReportLog.php
JulianVennen
requested changes
Oct 29, 2024
# Conflicts: # test/tests/Logs/AutoLogsTest.php
JulianVennen
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually, we extract the Minecraft version and the Java version in all crash reports, and also the version of the modloader. This does not always work with NeoForge, as there are different patterns in which NeoForge outputs the version.
In older versions, you could rely on the version always being at the end of in the crash report in this format:
NeoForge: net.neoforged:47.1.84Example from neoforge-1-20-1-server-report-entity.log
In newer versions, this pattern does not exist in the crash report. Instead, NeoForge is listed in the list of loaded mods. We can parse this list and read “neoforge” and the version from it.
Therefore, this PR not only changes the pattern for the general detection of crash reports from NeoForge, but also the extraction of the version of NeoForge from crash reports.