Add option to insert list in ets:insert, ets:lookup refactor #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 17, 2024
bettio
requested changes
Dec 22, 2024
TheSobkiewicz
force-pushed
the
thesobkiewicz/nifs/ets/refactor_insert
branch
4 times, most recently
from
76774f0 to
6ac7831
Compare
jakub-gonet
suggested changes
Jan 12, 2025
TheSobkiewicz
force-pushed
the
thesobkiewicz/nifs/ets/refactor_insert
branch
3 times, most recently
from
f54ef62 to
45eccdc
Compare
jakub-gonet
suggested changes
Jan 15, 2025
TheSobkiewicz
force-pushed
the
thesobkiewicz/nifs/ets/refactor_insert
branch
from
45eccdc to
e5908a2
Compare
bettio
requested changes
Jan 18, 2025
TheSobkiewicz
force-pushed
the
thesobkiewicz/nifs/ets/refactor_insert
branch
3 times, most recently
from
387dc1c to
54951ff
Compare
bettio
requested changes
Jan 22, 2025
|
I'm sorry about this additional round of comments, hope they can be somehow interesting to you and not just boring nitpicking. |
Don't worry, thank you for your patience when reviewing it ❤️ |
TheSobkiewicz
force-pushed
the
thesobkiewicz/nifs/ets/refactor_insert
branch
3 times, most recently
from
6e249eb to
0f71f40
Compare
|
I resolved open points I believe are still open. After that we are good I think. I would appreciate also a check from @jakub-gonet |
jakub-gonet
suggested changes
Jan 25, 2025
|
@bettio done. Found mostly nits and one missing |
TheSobkiewicz
force-pushed
the
thesobkiewicz/nifs/ets/refactor_insert
branch
2 times, most recently
from
9c15459 to
74dd710
Compare
Signed-off-by: Tomasz Sobkiewicz <[email protected]>
TheSobkiewicz
force-pushed
the
thesobkiewicz/nifs/ets/refactor_insert
branch
from
74dd710 to
4d84859
Compare
Signed-off-by: Tomasz Sobkiewicz <[email protected]>
TheSobkiewicz
force-pushed
the
thesobkiewicz/nifs/ets/refactor_insert
branch
from
4d84859 to
8103fe7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later
Changes:
Use Cases for the Helper Functions:
The new helper functions can be utilized in the following ETS operations to reduce code duplication:
Every mentioned function will be implemented after merging of this PR.