Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable optional RTIC support for Xiao_m0 #576

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

kadencartwright
Copy link

@kadencartwright kadencartwright commented Feb 21, 2022

Summary

It would be nice if the seeduino xiao_m0 supported RTIC. I'm a bit of a rust newbie, so maybe this is a naive fix¿? but it seems as simple as adding a feature flag to enable the rtic feature in the hal dependency.

Checklist

  • CHANGELOG.md for the BSP or HAL updated
  • All new or modified code is well documented, especially public items
  • No new warnings or clippy suggestions have been introduced (see CI or check locally)

@TDHolmes
Copy link
Contributor

I think this is the right thing to do, but could you add an RTIC example as well? You should be able to copy/paste an existing M0 one. I think feather_m0 has one?

@kadencartwright
Copy link
Author

kadencartwright commented Feb 22, 2022

@TDHolmes yea, I'll do that!

@kadencartwright
Copy link
Author

I had to update the Hal to dependency in Cargo.toml to reference the repo version using path = ... because a Monotonic related trait bound was not being satisfied otherwise. Feather M0 does the same in it's repo, which I would assume for this same reason.

@bradleyharden
Copy link
Contributor

@kadencartwright, we actually have a tier system for the BSPs. Tier 1 boards are kept up-to-date with master and must be updated with every change to the HAL. Tier 2 boards, on the other hand, are tied to a specific release of the HAL. We did this because it was becoming too much of a burden to update all of the BSPs for every change to the HAL.

Moving to a path = ... dependency would make this a Tier 1 board. But unfortunately, I don't think we want anymore Tier 1 boards at the moment. It sounds like you need an unreleased feature of the HAL to make this work, so I don't think we can merge this until we release v0.15. Fortunately, I don't think that is too far away (see #570).

@kadencartwright
Copy link
Author

@bradleyharden Ah, I see. Makes sense to me. What's the best thing to do with this PR for the time being -- should I just leave it here as is or is there something else more helpful I can do with it?

@TDHolmes
Copy link
Contributor

I think we just need to wait on this one until v0.15 is released

Copy link
Contributor

@TDHolmes TDHolmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make changes now that there has been a HAL release

@bradleyharden
Copy link
Contributor

Pinging @kadencartwright. Do you want to finish this up now that #570 has been merged?

@jbeaurivage jbeaurivage added the board support Related to support for a particular board label May 14, 2023
@kadencartwright kadencartwright marked this pull request as draft January 25, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
board support Related to support for a particular board
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants