Make UI appear on Qt::ApplicationActive for macOS #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the status icon plugin is used with close to system tray the UI main window is closed. On macOS there is not an easy way to make it reappear. The system tray activation trigger is disabled on macOS. This is for good reason due to one button mouse support and that this usually is intended to open the status/tray menu. Instead we should handle the application state change activate signal which will fire when the dock icon is clicked (it abstracts app delegate applicationShouldHandleReopen). This was originally fixed with audacious-media-player/audacious-plugins#174 but it is cleaner to decouple from any one window/skin implementation via connecting aud_ui_show to the QApplication directly.
jkl1337
added a commit
to jkl1337/audacious-plugins
that referenced
this pull request
Nov 22, 2024
This reverts commit 2f2d537. Better to handle this in libaudqt directly on the QApplication so that it is main window/skin agnostic. See audacious-media-player/audacious#1523
kaniini
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See audacious-media-player/audacious-plugins#174
Sorry, forgot about skins since I don't typically use them. Since the signal handler is sufficiently decoupled via
aud_ui_showanyway, I was thinking it would be cleaner to just hook this directly where the QApplication is instantiated along with the other platform specific code.