fix(webpack): avoid unnecessary breaking change on argument #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this fix, `au run --analyze` `au run --hmr` will continue to work.
|
@Sayan751 pls review this fix. |
|
@EisenbergEffect I cannot use github tool to request review from @Sayan751. Is there some member setup you need to do? |
|
For some reason you can't just add anyone as a reviewer. I don't know why GH has that restriction. We can always ping @Sayan751 manually and ask him to take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this fix,
au run --analyzeau run --hmrwill continue to work.