Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3D measuring tool #397

Open
wants to merge 3 commits into
base: 1.1-dev
Choose a base branch
from
Open

3D measuring tool #397

wants to merge 3 commits into from

Conversation

Pessimistress
Copy link
Contributor

avs-measurment

To test locally:

git checkout x/measure-layer
yarn bootstrap
cd test/app/measure
yarn start-local

There are several ways we can package this. Changes to the core can be published as [email protected] (it depends on a non-production release of deck.gl). The TapeMeasureLayer (where majority of the logic is) can either be

  • ported into nebula.gl
  • published via @streetscape.gl/layers

ChangeList

  • Bump deck.gl to 7.4.0-alpha.1 (with 3d picking feature)
  • Upgrade PointCloudLayer to use [email protected]'s shader hooks (required by 3d picking)
  • Add test app

@supersonicclay @marionleborgne @jlisee

@ibgreen
Copy link
Contributor

ibgreen commented Oct 3, 2019

This looks really neat! And as far as I can see this tool does not have any react dependencies which is great.

These are just longer term thoughts:

It would be great if for next release we could unbundle this from streetscape and put this in a helper module in e.g. deck.gl or nebula.gl.

Perhaps there is opportunity to create a "toolkit" for such measuring tools, e.g.

  • an area calculation tool (which we presumably would want to build on nebula polygon rendering).
  • a volume calculation tool
  • a point cloud volume point counter tool
  • a base class for user to create custom tools...

And perhaps the user could declaratively specify a selection of these tools, making them accessible in pydeck and the playground as well?

@ibgreen
Copy link
Contributor

ibgreen commented Oct 3, 2019

@romaxa FYI

@Pessimistress Pessimistress changed the base branch from x/picking-fix to master October 3, 2019 03:10
@coveralls
Copy link

coveralls commented Oct 3, 2019

Coverage Status

Coverage decreased (-0.3%) to 14.942% when pulling 43ade3d on x/measure-layer into cf5dd9a on master.

@supersonicclay
Copy link

I'd love to see this functionality in nebula.gl. I think we have a lot of the plumbing in place to be able to support this.

@Pessimistress Pessimistress changed the base branch from master to 1.1-dev October 5, 2019 03:31
@Pessimistress Pessimistress changed the title [POC] 3D measuring tool 3D measuring tool Oct 5, 2019
@CLAassistant
Copy link

CLAassistant commented Apr 16, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Xiaoji Chen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@supersonicclay
Copy link

supersonicclay commented Jun 12, 2020

We have distance and angle measurement tools in nebula now. Can we refactor this PR to use it?

@alexhaislip
Copy link

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants