-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3D measuring tool #397
base: 1.1-dev
Are you sure you want to change the base?
3D measuring tool #397
Conversation
This looks really neat! And as far as I can see this tool does not have any react dependencies which is great. These are just longer term thoughts: It would be great if for next release we could unbundle this from streetscape and put this in a helper module in e.g. deck.gl or nebula.gl. Perhaps there is opportunity to create a "toolkit" for such measuring tools, e.g.
And perhaps the user could declaratively specify a selection of these tools, making them accessible in pydeck and the playground as well? |
@romaxa FYI |
164e752
to
708c566
Compare
I'd love to see this functionality in nebula.gl. I think we have a lot of the plumbing in place to be able to support this. |
708c566
to
43ade3d
Compare
Xiaoji Chen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
We have distance and angle measurement tools in nebula now. Can we refactor this PR to use it? |
Nice! |
To test locally:
git checkout x/measure-layer yarn bootstrap cd test/app/measure yarn start-local
There are several ways we can package this. Changes to the core can be published as
[email protected]
(it depends on a non-production release of deck.gl). TheTapeMeasureLayer
(where majority of the logic is) can either benebula.gl
@streetscape.gl/layers
ChangeList
PointCloudLayer
to use[email protected]
's shader hooks (required by 3d picking)@supersonicclay @marionleborgne @jlisee