Specify return type of main() in conftest.c #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryandesign
reviewed
Oct 10, 2024
| @@ -711,7 +711,7 @@ cross_compiling=$ac_cv_prog_cc_cross | |||
| cat > conftest.$ac_ext <<EOF | |||
| #line 713 "configure" | |||
| #include "confdefs.h" | |||
| main(){return(0);} | |||
| int main(){return(0);} | |||
There was a problem hiding this comment.
This is C code, right? Not C++? If so, specify the function arguments:
Suggested change
| int main(){return(0);} | |
| int main(void){return(0);} |
There was a problem hiding this comment.
Yes, that's right.
However, there also are thousands of this description in other configure files.
The purpose of this PR is to make the minimum fix to be able to build on macOS, and I don't intend to fix thousands of things.
ryandesign
approved these changes
Nov 22, 2024
|
It's not just MacOS, this is now required to build on Fedora Linux and Arch. That said, I applied this PR myself and confirmed this is functioning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes following error while building on macOS.