Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDKs support for Control Your Own Key #671

Merged
merged 4 commits into from
Oct 16, 2024
Merged

SDKs support for Control Your Own Key #671

merged 4 commits into from
Oct 16, 2024

Conversation

tanya732
Copy link
Contributor

@tanya732 tanya732 commented Oct 9, 2024

Changes

  • added rekey endpoint in KeyEntity
  • created custom request class called EmptyBodyVoidRequest

References

auth0/node-auth0#1041

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@tanya732 tanya732 requested a review from a team as a code owner October 9, 2024 03:54
@jimmyjames
Copy link
Contributor

Just wondering if we can use the existing EmptyBodyRequest and specify TypeReference<Void> as the type, without adding a new type? And if so, if we think having a dedicated new type for it provides improvements regardless?

@tanya732
Copy link
Contributor Author

Just wondering if we can use the existing EmptyBodyRequest and specify TypeReference<Void> as the type, without adding a new type? And if so, if we think having a dedicated new type for it provides improvements regardless?

While using EmptyBodyRequest, we have to make changes while parsing the response and doing so may add failures for other endpoints

@tanya732 tanya732 merged commit 2a31b29 into master Oct 16, 2024
8 checks passed
@tanya732 tanya732 deleted the sdk-5040-cyok branch October 16, 2024 09:23
@tanya732 tanya732 mentioned this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants