Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(publish): only run on manual workflow, remove tag check #608

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

ewanharris
Copy link
Contributor

Changes

Given that we create the release/tag via the API, the local git repo doesn't get updated so the poetry dynamic versioning still can't find the tag.

To make things simpler for now, I propose we make this repo a manual release trigger and change the new release flow to:

  • Release PR made
  • Release PR merged
  • Tag created and merged
  • Release workflow triggered

References

Please include relevant links supporting this change such as a:

  • support ticket
  • community post
  • StackOverflow post
  • support forum thread

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@ewanharris ewanharris merged commit 6b1199f into master Feb 26, 2024
15 checks passed
@ewanharris ewanharris deleted the ewanharris-patch-1 branch February 26, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants