Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed pull_request_target to pull_request #631

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Changed pull_request_target to pull_request #631

merged 1 commit into from
Oct 9, 2024

Conversation

arpit-jn
Copy link
Contributor

@arpit-jn arpit-jn commented Oct 4, 2024

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Change pull_request_target to pull_request for better security.
Remove the authorize job from the list of jobs defined in that workflow.
Remove the dependency on authorize job for other jobs in that workflow by looking for the line needs: authorize.

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@arpit-jn arpit-jn requested a review from a team as a code owner October 4, 2024 12:47
@arpit-jn arpit-jn merged commit 5a58ffc into master Oct 9, 2024
14 of 16 checks passed
@arpit-jn arpit-jn deleted the security-ci-pull_request_target-1 branch October 9, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desusai7 desusai7 desusai7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arpit-jn @desusai7