-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GH-501] Fix Retry Mechanism to Handle Burst Limit Due to Clock Skew Issue #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #523 +/- ##
==========================================
+ Coverage 95.47% 95.78% +0.31%
==========================================
Files 58 58
Lines 11304 11332 +28
==========================================
+ Hits 10792 10854 +62
+ Misses 391 359 -32
+ Partials 121 119 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6 tasks
ramya18101
previously approved these changes
Mar 11, 2025
ramya18101
approved these changes
Mar 11, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
This PR improves the retry mechanism to properly handle burst limit errors caused by clock skew. Previously, the logic only detected global rate limits and didn't correctly account for burst limits, leading to unnecessary failures.
Key changes:
Retry-After
header when present.X-Ratelimit-Reset
, ensuring clock skew does not cause incorrect retry behavior.These changes ensure more reliable request handling and prevent premature request failures due to incorrect rate limit calculations.
📚 References
🔬 Testing
Retry-After
is correctly interpreted and applied.📝 Checklist