Merge pull request #67 from mikeops/error-on-missing-endpoint

Converts exception to error when calling getSamlRequestUrl with an empty identityProviderUrl
auth0 · Jan 5, 2018 · 054dcec · 054dcec
2 parents 1881504 + 0c8d19f
commit 054dcec
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 2 deletions.
diff --git a/lib/passport-wsfed-saml2/samlp.js b/lib/passport-wsfed-saml2/samlp.js
@@ -195,6 +195,11 @@ Samlp.prototype = {
 
   getSamlRequestUrl: function (opts, callback) {
     var options = xtend(opts || {}, this.options);
+
+    if (!options.identityProviderUrl) {
+      return callback(new Error('Missing value for the identity provider login URL'));
+    }
+
     var parsedUrl = url.parse(options.identityProviderUrl, true);
 
     this.getSamlRequestParams(options, function (err, params) {

diff --git a/test/samlp.tests.js b/test/samlp.tests.js