[ULP-3649][ULP-3712] Fix: URL fragments in SAML Sign in URLs #171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Purpose: This PR solves an existing bug in SAML request URL construction during sign in. If the URL contains any fragments, the fragments are not always appended at the end of the URL after all the query params.
Eg: When parsing https://example.com/#Test.
The PR solves the problem by stripping fragments and query from URL and then appending them in the correct order after parsing stage.
References
ESD Ticket: https://auth0team.atlassian.net/browse/ESD-19892 for more context
Testing
Added Unit tests for this fix covering typical URL examples with/without fragments & with/without query params
Checklist
master