Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Broken Test Case #1120

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Fixed Broken Test Case #1120

wants to merge 9 commits into from

Conversation

duedares-rvj
Copy link
Contributor

@duedares-rvj duedares-rvj commented Jan 14, 2025

🔧 Changes

  1. Re-recorded TestAccDataClients and TestAccClientOIDCLogout test case allowing the workflow to pass.
  2. In auth0_client, set oidc_logout as computed to avoid noisy plan.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@duedares-rvj duedares-rvj requested a review from a team as a code owner January 14, 2025 11:58
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.21%. Comparing base (6387564) to head (922c35c).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1120      +/-   ##
==========================================
- Coverage   89.29%   89.21%   -0.09%     
==========================================
  Files         130      130              
  Lines       18027    18055      +28     
==========================================
+ Hits        16097    16107      +10     
- Misses       1363     1379      +16     
- Partials      567      569       +2     
Files with missing lines Coverage Δ
internal/auth0/client/resource.go 98.50% <100.00%> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants