Remove transaction metadata from bulk imports #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The entire bulk import is a single transaction, and there is no message in which we can provide the metadata, so disallow it
vroldanbet
approved these changes
Oct 1, 2024
tstirrat15
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
The conversation was that ImportBulk and BulkImport both use streaming for network reasons, but the endpoint uses a single DB transaction per request to ensure that when you receive an error, you know what was and wasn't applied, which wouldn't be so easy if it were client streaming. We may revisit this, but in the meantime we'll use a header to get similar behavior out of the current implementation of the bulk endpoints.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The entire bulk import is a single transaction, and there is no message in which we can provide the metadata, so disallow it